Complex impedance fixes #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msilvafe
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
I haven't used this module in ages. Assuming you have tested with the updated changes (have you?), I'm happy to have them merged.
(ahh didn't realize this was draft...so I assume you're still testing but my statement still holds minimal flow down issues as this isn't used at site so if you test at pton and get it working happy to get it merged in)
|
Whoops, commit message for f0083c7 should have been "Set |
jlashner
approved these changes
Jul 16, 2024
Since the default flux ramp rate is 4kHz so we can only get half of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complex_impedance module has developed a number of bugs, e.g. #428, and this is my attempt to fix them.
Draft PR until able to test.